- IvanVostrikov changed review status to Awaiting Review
- 1 mo
Texel Density Checker is toolset for working with Texel Density.
with Addon you can:
Texel Density Checker simple for use. You need select your mesh (or faces) and texture size and just click button.
Refactoring of using resources by name
This extension does not require special permissions.
While I didn't test this, it looks like sys.modules
access is incorrect and wont work as expected.
modules_full_names[current_module_name] = ('{}.{}'.format(__name__, current_module_name))
Should be modules_full_names[current_module_name] = ('{}.{}'.format(__package__, current_module_name))
Since the valid is later used to lookup sys.modules
.
Fixed
Add-on uses bpy.data
module to look up images and materials with string names. This is very unstable and can lead to errors and add-on failing if user changes name of either of those, as well as if there are multiple scenes in which add-on is used.
Instead of using names, you can assign custom attributes to both (which users cant access) and check with them instead.
Also, because every material is using the same image, you can't have different types of images on different objects. Is that supposed to be? Feels a little less flexible.
Converted to Draft
Ready for review
Fixed using resource by name
Also, because every material is using the same image, you can't have different types of images on different objects. Is that supposed to be? Feels a little less flexible.
It's Ok. This is by desing.
Approved
Somehow I missed the Blender logo in the thumbnail and preview images. They should be removed, it is against Branding guidelines.
updated featured image, previews
Removed Blender logo from all images
Thanks
Sign in to comment.
Ready for review