Create extensive Render Presets in a specific folder (can be on a shared drive) and apply them on the fly.
This addon also supports applying render preset through python (background script in a pipeline for example).
This extension requests the following permission:
Reading and writing json preset files in a user-defined location
Thanks for the submission.
Are you the original creator of the add-on or is this a fork? Github account has different username.
Some changes have to be made there. First and foremost, this is not adapted to EEVEE next, it sets legacy eevee properties which no longer exists and doesn't work for EEVEE next, as its properties are ignored.
From .zip file unnecessary files such as .github
, .gitignore
, and especially resources
folder have to be removed. Only what is needed for add-on to run.
We do not allow donation links inside the Blender itself, so it has to be removed from preferences, but you can put it in the description on the website.
Files permission needs to clarify what is it being used for. This is generic description.
Optionally you can remove commented out lines in blender_manifest to make it easier to read. And as personal feedback, I'm not sure how convenient and safe it is to expose all properties as strings, especially booleans, when simple mistake like "Fals" can cause it to not set property.
Thanks for the review, i just updated a new version with these changes :
Blender extension platform is designed to be a safe place for blender users to download verified community addons/extensions. A lot of users will be using this from blender and from the website, without any need to look further (addon external website...) which is the point of using a centralized web place like this. So through a basic utilisation, user will never know there is donation available somewhere, except by clicking on a vague link named "website".
I get that blender team is trying to uniformize the addons through this platform, and you have to ditch advertising or annoying external links, but i find this disturbing that a community driven platform, relying on non-paid python developper and community members for review, do not allow some unharming donation hints.
Maybe this should be on extension page instead of in blender itself, but it should be clear and "officially supported", not under a generic "website link" which almost nobody will click (again, the purpose of this platform is to centralized extensions and avoid the need to browse the entire web on every blender install).
Sorry for the grunt, but this is the first time a blender foundation initiative feels weird to me, and i don't like it.
If there is any chance to discuss this further, this could be interesting i think.
About eevee legacy/eevee next properties, the addon get every property attached to blender classes (in this case scene.render.eevee), i checked, this object contains the majority of eevee next settings, and the addon iterates through it. To me there is no issue here as it is not hardcoded. Maybe some legacy props are in blender code and shows in the render preset gui, but this comes from blender code itself. The only problem was i activated some properties by hand, to be automatically saved in a new preset, one of them was deprecated, and failed silently, so i removed it. Don't hesitate if i'm not clear, english is not my native language.
The new version of the extension is ready for review.
You can put donation button in description if you wish and Website link isn't enough. We wish to keep Blender entirely ad-free experience, and while donations are not ads of course, at this point we don't want to allow any kind of external links to not open can of worms, because drawing the line between what is allowed or not will open a can of worms and will require case-to-case decision making, which is going to take away from limited moderation time.
Ok i'll add it in the description and of course i get that this can't be case by case decision. In my opinion it lacks a button from extension in blender préférences, or on the extension webpage, "official button" just a link which does not add extra moderation time. Donations are not a real "stable income" for me, but i think it is important to be able to communicate officialy about that through blender channels like this one. Anyway thanks for the feedback and waiting for your review :)
EEVEE > Sampling > Viewport > Samples isn't preserved by the add-on, and its quite literally the first render property showed by default in Blender. I'm unable to test further than that. I think your method of getting properties isn't covering EEVEE Next well. Please look into that and only resubmit for review when you've tested and made sure that it works.
There was a syntax error for taa_render_samples (eevee render samples) which was not on by default, i am changing this, but the viewport samples (taa_samples) is not part of the render, but part of the preview (or playblast) so it is by design that it is not included.
But did you see that the property is still available for save in a preset, even if not enabled ? I can't attach screenshot here, but you can untick "Hide unused properties" to make all render properties showed, then just enable them to include them in the preset.
The idea here is to just enable for save some basics need for a render preset (render samples...), but after that the addon get all these properties programmatically in a bunch of blender python class (scene.eevee, scene.render...) to make it "futureproof" (if properties are added because eevee next next for examples, they will be available for user without any update of the addon.
Tell me if i'm not clear or if there is a problem with this behaviour.
Thanks for the feedbacks
Sign in to comment.
Ready for review